Fix test for recommended rule doc notice
#1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
reviewed
Nov 23, 2021
| @@ -236,7 +236,7 @@ test('Every rule has a doc with the appropriate content', t => { | |||
| // Decide which notices should be shown at the top of the doc. | |||
| const expectedNotices = []; | |||
| const unexpectedNotices = []; | |||
| if (index.configs.recommended.rules[`unicorn/${ruleName}`]) { | |||
| if (index.configs.recommended.rules[`unicorn/${ruleName}`] === 'error') { | |||
| expectedNotices.push('configRecommended'); | |||
There was a problem hiding this comment.
!= 'off'，, I believe template-indent was configured as warn.
There was a problem hiding this comment.
Thanks, fixed.
There was a problem hiding this comment.
Had to switch to includes to avoid no-negated-condition.
|
This is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in this test so we mistakenly added the
recommendedrule notice to some rule docs that are not in therecommendedconfig.The test will now correctly verify that the
recommendedrules include this notice and non-recommended rules don't.