filename-case: Ignore $ in filenames
#1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
reviewed
Dec 2, 2021
test/filename-case.mjs
Outdated
| @@ -79,6 +79,7 @@ test({ | |||
| testCase('src/foo/___foo-bar.js', 'kebabCase'), | |||
| testCase('src/foo/_FooBar.js', 'pascalCase'), | |||
| testCase('src/foo/___FooBar.js', 'pascalCase'), | |||
| testCase("src/foo/$foo.js"), | |||
There was a problem hiding this comment.
Can you also add an invalid case with filename contains $?
There was a problem hiding this comment.
$ in the filename will never cause the filename to be invalid because this character has nothing to do with casing.
sindresorhus
approved these changes
Dec 27, 2021
sindresorhus
changed the title
filename-case: Ignore $ in filenames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1627
There is no test case that demonstrates why
$should not be ignored.