Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefer-json-parse-buffer rule #1676

Merged
merged 20 commits into from
Dec 31, 2021
Merged

Add prefer-json-parse-buffer rule #1676

merged 20 commits into from
Dec 31, 2021

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Dec 30, 2021

Fixes #1273

@sindresorhus
Copy link
Owner

It also needs to handle fs.readFile(file, {encoding: 'utf8'}).

sindresorhus
sindresorhus requested changes Dec 30, 2021
View reviewed changes
rules/prefer-json-parse-buffer.js Outdated Show resolved Hide resolved
rules/prefer-json-parse-buffer.js Outdated Show resolved Hide resolved
@fisker fisker marked this pull request as draft December 31, 2021 02:09
@fisker fisker marked this pull request as ready for review December 31, 2021 02:32
@sindresorhus sindresorhus merged commit 84c9c70 into sindresorhus:main Dec 31, 2021
@sindresorhus
Copy link
Owner

Perfect 👍

@fisker fisker deleted the prefer-json-parse-buffer branch December 31, 2021 11:11
@remcohaszing remcohaszing mentioned this pull request Jan 8, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule proposal: prefer-json-parse-buffer
2 participants
@fisker @sindresorhus