Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
prefer-event-target
rule #1792Add
prefer-event-target
rule #1792Changes from 1 commit
2308764
71bfe97
8c89d6e
8a46b53
669a52c
8ee62d2
c86161f
d15300b
8257add
035e560
532fd9b
1b906ed
e1c432d
3ec045d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You added this body type check, but not tests covers this, is it possible to have different body here? Maybe in TypeScript? Please test it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, but I think I actually don't understand this feedback.
Is it possible to handle typescript with this lib?
I tried to insert a simple typescript statement (
let a: number = 3;
) and tested, but it seems like parsing error occurs.I think class declaration's with other body type seems not possible, according to this ECMA document in Javascript,
In case of Typescript, this specification's 117 page
And FYI, when I added this selector, I referenced to
/rules/no-static-only-class.js
's selector.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if it's possible to have different body in TS, I guess it's fine to keep this just in case.
If you find anything want test, you can use
There are examples in other rules.