Support RegExp v flag

[fisker]

No description provided.

[fisker]

@novemberborn Sorry for bothering you.

As you can see test is failing in this PR. We use a old version of ava

eslint-plugin-unicorn/package.json

Line 71 in 1629ebe

"ava": "^3.15.0",

, we use it weird, we delete snapshots, and force ava to regenerate snapshots, to make sure snapshots won't change.

eslint-plugin-unicorn/.github/workflows/main.yml

Lines 40 to 45 in 1629ebe

	- run: rm -rf test/snapshots
	# Force update snapshots, https://github.com/avajs/ava/discussions/2754
	- run: npx c8 ava --update-snapshots
	env:
	AVA_FORCE_CI: not-ci
	- run: git diff --exit-code

It works well until this PR. I already regenerate snapshots locally, but it still changes on CI. Maybe you known what possibly go wrong?

[novemberborn]

Looks like a test failed, it didn’t get to the diffing of the snapshots. And only in Node 20. Wouldn’t that be a real bug?

we use it weird, we delete snapshots, and force ava to regenerate snapshots, to make sure snapshots won't change

That sounds like what AVA checks for in CI, what am I missing? Is this to handle differences between Node versions?

[fisker]

Looks like a test failed, it didn’t get to the diffing of the snapshots.

You are right.. I thought that's the "lint-test" job, which does the snapshot diff check, but it's not, really sorry.

Wouldn’t that be a real bug?

Run test on Node.js v20 locally, tests all passed.
Run out of ideas...

[fisker]

Should be something wrong here

eslint-plugin-unicorn/rules/prefer-regexp-test.js

Lines 79 to 92 in 1629ebe

	const isRegExpWithoutGlobalFlag = (node, scope) => {
	const staticResult = getStaticValue(node, scope);
	// Don't know if there is `g` flag
	if (!staticResult) {
	return false;
	}
	const {value} = staticResult;
	return (
	Object.prototype.toString.call(value) === '[object RegExp]'
	&& !value.global
	);
	};

I'll try to fix it later.

[fisker]

@novemberborn You are right, there is a bug indeed, thanks for your help.