-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefer-number-properties
: Add checkNaN
option
#2315
Conversation
CI error not related I believe |
// @Richienb |
Should the option be |
Could we maybe set it to false by default? (breaking) |
👍 |
Not sure why this is failing, will try to take a look |
Co-authored-by: Richie Bendall <richiebendall@gmail.com>
Yeah, sorry y'all — when I turn it off by default, a bunch of tests are failing and even though I modify them to be like Infinity checks, there are errors I do not have the time to look into it, so let's focus on adding this feature in this PR See f544b63 to view my latest try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like some examples in the docs
That's ok, we can change it in the next PR. Added to the tracking issue |
I added one more, what else would you like to see? |
I can't request a review so just tagging 🙏 |
prefer-number-properties
, add checkNaN
prefer-number-properties
: Add checkNaN
option
I think the
NaN
check should also be toggleable, because I use it like I usenull
(absence of an object), to represent an absence of a number; and sincenull
is global, this setting lets me be more consistentThanks for maintaining this amazing plugin!