Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore regexp-tree parse error on regex-shorthand rule #452

Closed
wants to merge 1 commit into from

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Nov 30, 2019

If a regex can be parsed by ESLint, but can't parse by regexp-tree, we don't know if this regex can be optimized, we should just ignore it

@fisker fisker changed the title Skip regexp-tree parse error on regex-shorthand rule Ignore regexp-tree parse error on regex-shorthand rule Nov 30, 2019
@fisker
Copy link
Collaborator Author

fisker commented Nov 30, 2019

close in favor of #454

@fisker fisker closed this Nov 30, 2019
@fisker fisker mentioned this pull request Nov 30, 2019
@fisker fisker deleted the skip-regexp-tree-error branch May 4, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant