consistent-function-scoping: Ignore within useEffect in React Hooks

rules/consistent-function-scoping.js

@@ -60,6 +60,13 @@ function checkReferences(scope, parent, scopeManager) {
 		);
 }
 
+const isReactHooks = scope =>
+	scope.block &&
+	scope.block.parent &&
+	scope.block.parent.callee &&
+	scope.block.parent.callee.type === 'Identifier' &&
+	scope.block.parent.callee.name === 'useEffect';
+
 function checkNode(node, scopeManager) {
 	const scope = scopeManager.acquire(node);
 	if (!scope) {
@@ -87,7 +94,7 @@ function checkNode(node, scopeManager) {
 	}
 
 	const parentScope = scopeManager.acquire(parentNode);
-	if (!parentScope || parentScope.type === 'global') {
+	if (!parentScope || parentScope.type === 'global' || isReactHooks(parentScope)) {
 		return true;
 	}
 

test/consistent-function-scoping.js

@@ -191,6 +191,12 @@ ruleTester.run('consistent-function-scoping', rule, {
 				return Bar;
 			};
 		`,
+		// React Hooks
+		outdent`
+			useEffect(() => {
+				function foo() {}
+			}, [])
+		`,
 		// #391
 		outdent`
 			const enrichErrors = (packageName, cliArgs, f) => async (...args) => {
@@ -362,6 +368,25 @@ ruleTester.run('consistent-function-scoping', rule, {
 				}
 			`,
 			errors: [functionError]
+		},
+		// React Hooks
+		{
+			code: outdent`
+				useEffect(() => {
+					function foo() {
+						function bar() {
+						}
+					}
+				}, [])
+			`,
+			errors: [
+				{
+					ruleId: 'consistent-function-scoping',
+					messageId: 'FunctionDeclaration',
+					column: 3,
+					line: 3
+				}
+			]
 		}
 	]
 });