Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ecmaVersion to 2021 #820

Merged
merged 4 commits into from
Sep 10, 2020

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Sep 1, 2020

No description provided.

@fisker
Copy link
Collaborator Author

fisker commented Sep 1, 2020

This requires #815

@sindresorhus
Copy link
Owner

There are some more places to update:

eslint-plugin-unicorn/index.js
13:				ecmaVersion: 2020,

eslint-plugin-unicorn/test/prefer-starts-ends-with.js
8:		ecmaVersion: 2020

eslint-plugin-unicorn/test/better-regex.js
7:		ecmaVersion: 2020

eslint-plugin-unicorn/test/prefer-node-remove.js
15:		ecmaVersion: 2020

eslint-plugin-unicorn/test/prefer-node-append.js
9:		ecmaVersion: 2020

eslint-plugin-unicorn/test/prefer-optional-catch-binding.js
11:		ecmaVersion: 2020

eslint-plugin-unicorn/test/no-for-loop.js
8:		ecmaVersion: 2020
14:		ecmaVersion: 5

eslint-plugin-unicorn/test/new-for-builtins.js
8:		ecmaVersion: 2020,

eslint-plugin-unicorn/test/no-null.js
12:		ecmaVersion: 2020,

eslint-plugin-unicorn/test/number-literal-case.js
11:		ecmaVersion: 2020

eslint-plugin-unicorn/test/no-fn-reference-in-iterator.js
27:		ecmaVersion: 2020

eslint-plugin-unicorn/test/prefer-spread.js
8:		ecmaVersion: 2020

eslint-plugin-unicorn/test/no-keyword-prefix.js
7:		ecmaVersion: 2020,
220:			parserOptions: {ecmaVersion: 6},
225:			parserOptions: {ecmaVersion: 6},

eslint-plugin-unicorn/test/no-reduce.js
13:		ecmaVersion: 2020

eslint-plugin-unicorn/test/import-style.js
10:		ecmaVersion: 2020
588:		ecmaVersion: 2020

eslint-plugin-unicorn/test/no-console-spaces.js
8:		ecmaVersion: 2020

eslint-plugin-unicorn/test/no-useless-undefined.js
11:		ecmaVersion: 2020
245:		ecmaVersion: 2020

eslint-plugin-unicorn/test/no-process-exit.js
8:		ecmaVersion: 2020,

eslint-plugin-unicorn/test/prefer-set-has.js
10:		ecmaVersion: 2020,

eslint-plugin-unicorn/test/prefer-array-find.js
17:		ecmaVersion: 2020,

eslint-plugin-unicorn/test/no-object-as-default-parameter.js
9:		ecmaVersion: 2020
175:		ecmaVersion: 2020

eslint-plugin-unicorn/test/prevent-abbreviations.js
14:		ecmaVersion: 5
23:		ecmaVersion: 2020,

eslint-plugin-unicorn/test/integration/config.js
14:		ecmaVersion: 2020,

eslint-plugin-unicorn/test/consistent-function-scoping.js
10:		ecmaVersion: 2020,
655:		ecmaVersion: 2020,

eslint-plugin-unicorn/test/throw-new-error.js
9:		ecmaVersion: 2020

eslint-plugin-unicorn/test/prefer-number-properties.js
32:		ecmaVersion: 2020

eslint-plugin-unicorn/test/catch-error-name.js
10:		ecmaVersion: 2020

@fisker
Copy link
Collaborator Author

fisker commented Sep 1, 2020

I think they don't have to use the latest?

@sindresorhus
Copy link
Owner

Maybe not always, but it's sometimes hard to see when it could have been useful. And it's annoying to have to individually judge every time it updates. Wouldn't it be easier if everything was the same? We could maybe define a shared constants and import it into every test. Or better yet, some kind of custom test helper, like #554

@fisker
Copy link
Collaborator Author

fisker commented Sep 2, 2020

I'll work on #554 when I have time.

@fisker
Copy link
Collaborator Author

fisker commented Sep 2, 2020

@sindresorhus sindresorhus merged commit a78cea3 into sindresorhus:master Sep 10, 2020
@fisker fisker deleted the update-ecma-version branch September 11, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants