Add buffer option to be able to disable buffering
#133
Conversation
|
|
|
@spalger Still interested in finishing this? |
spalger
force-pushed
the
fix/127/disable-buffering
branch
from
d255279
to
7de85ff
Compare
|
@sindresorhus yep, sorry, got lost in the pile. Should be good to go now |
spalger
force-pushed
the
fix/127/disable-buffering
branch
from
11ac4e3
to
7642e47
Compare
| @@ -358,7 +380,7 @@ test('err.code is 3', code, 3); | |||
| test('err.code is 4', code, 4); | |||
|
|
|||
| test('timeout will kill the process early', async t => { | |||
| const err = await t.throws(m('delay', ['3000', '0'], {timeout: 1500})); | |||
| const err = await t.throws(m('delay', ['60000', '0'], {timeout: 1500})); | |||
There was a problem hiding this comment.
Did this in an effort to fix the AppVeyor failure here: https://ci.appveyor.com/project/sindresorhus/execa/build/1.0.337
Not sure if this others see this type of failure regularly, but it passes locally and shouldn't be effected by my changes, so I'm not sure what else I should do about it. (note: I initially tried a delay 5 seconds and that wasn't enough to get it passing on AppVeyor)
There was a problem hiding this comment.
AppVeyor is known for being really slow and annoying. The usual fix is what you've done and just increase the timeouts a lot.
sindresorhus
changed the title
maxBuffer: nullbuffer option to be able to disable buffering
|
Thank you 🙌 |
Fixes #127
The issue describes adding a
buffer: falseoption, which seemed to be in conflict with themaxBufferoption that's already supported, so rather than adding a new option this PR disables buffering of stdio whenmaxBuffer: nullis used.