New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactoring on `cleanup` option #268

Merged

sindresorhus merged 2 commits into master from feature/cleanup-refactoring

May 30, 2019

Collaborator

ehmicky commented May 30, 2019 •

edited

Loading

This is a small code refactoring that puts all cleanup() in a single place.

This uses pFinally instead of then() because that promise might be rejected in the future (I've got an upcoming PR that does that).

ehmicky added 2 commits

May 30, 2019 10:00


          Small refactoring on cleanup option

739f683


          Add comment

75a2599

sindresorhus merged commit 3b103f8 into master

sindresorhus deleted the feature/cleanup-refactoring branch

May 30, 2019 12:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment