Measure upload speed

[danielhuang]

Closes #27

[danielhuang]

Upload speed measuring works, however a flag is not yet implemented

[danielhuang]

Progress display still feels a bit ugly

[mattstrayer]

Can this get merged in?

[sindresorhus]

Maybe we should use the ↓ ↑ arrows to indicate download/upload?

[sindresorhus]

Can this get merged in?

It will be merged when it's ready. If you want it merged faster, help out by reviewing and testing this PR ;)

[sindresorhus]

@GloriousYellow This is looking great! 🙌

[HaShAkO]

Hi, is there any plan to include latency as well ? , great job =)

[HavishNetla]

prevResult is not being set to anything in api.js

[danielhuang]

I'm thinking of using ⇣⇡ arrows, like in pure. How does that sound?

However, I'm not sure if these arrows should be printed if invoked through a non-tty.

[danielhuang]

I've implemented a quick prototype:


I sort of feel like the arrows take away the original "feel" of this tool.

[danielhuang]

With the other type of arrows:

Maybe this would work better?

[sindresorhus]

@GloriousYellow The last one looks good. Let's go with that.

[erasmuswill]

Any updates on this?

[sindresorhus]

@GloriousYellow Still interested in finishing this? :)

[danielhuang]

I am not completely satisfied with the naming of --verbose; it doesn't imply measurement of upload speed.

[danielhuang]

Should we make the download speed indicator green during the upload test?

[danielhuang]

[danielhuang]

When completed

[mattstrayer]

I think it looks better with the blue. The animation on the left indicates enough to the user when a test is running and when it is complete

[sindresorhus]

Should we make the download speed indicator green during the upload test?

👍

[sindresorhus]

Thank you for your work on this, @GloriousYellow :)

[danielhuang]

There is a failing test; would that be a concern?

[sindresorhus]

Already fixed in a follow-up commit.