minimumBytes was not properly deprecated, breaking change

[arciisine]

in 14.0.0 (a major release), minimumBytes was removed (not deprecated) (#319 ).

This has had a breaking change on code that relies on that constant being exposed. A proper deprecation path would be appreciated.

[sindresorhus]

It's still there:

file-type/core.js

Line 60 in b280b91

const buffer = Buffer.alloc(minimumBytes);

[Borewit]

It's still there:

file-type/core.js

Lines 60 to 63 in b280b91

	const buffer = Buffer.alloc(minimumBytes);
	await tokenizer.ignore(ignoreBytes);
	await tokenizer.peekBuffer(buffer, {length: 512, mayBeLess: true});

The usage of minimumBytes (which is private value now) does not make any sense in that line, it should be 512 or the length: 512 should be removed. (fixing PR: #329)

You are right @arciisine, it was already depricated since (#286, v13.0.0), and now it has been removed.

You can pass any number of bytes @arciisine. There is no special number of bytes anymore, other then the total number of bytes of the file you wish to analyze.

[arciisine]

Just to reiterate the PR indicated it was deprecated but it was actually removed from the public API and is no longer available to use. I plan on updating my code to not rely on that constant, but the wording of the change may surprise others as well.

…

On Sun, Feb 9, 2020, 11:18 AM Borewit ***@***.***> wrote: Closed #328 <#328>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#328?email_source=notifications&email_token=AAJUUL6J356DULA4DKKPXHLRCAUGPA5CNFSM4KSBWYFKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWQGD4XA#event-3020701276>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJUULZWNL6635RIKMN2QHLRCAUGPANCNFSM4KSBWYFA> .

[Borewit]

I plan on updating my code to not rely on that constant, but the wording of
the change may surprise others as well.

Very good. Try to use fromFile() if possible. I updated the title of #319 and release description of v14.0.0.