New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MPEG-4 Audiobook (.m4b) #177
Conversation
Tests are failing as the audiobook fixture is being detected as |
Not sure if it is actually that simple to pick out the |
@Borewit Still interested in finishing this? :) |
You may close the issue. I started this PR based on the assumption it could be extracted with the first bytes, which appears not to be the case. I went through the changes of this PR, and kept a minor code correction, which I moved to PR. I use this module for music-metadata to determine the audio file type, based on the content, as a fallback in case the audio type wasn't provided by the user. As long as I get one of the MPEG-4 MIME-types it works for me. Feel free to ping me on any discussion regarding audio file type, or on requests to cover new audio file types. |
I understand. No worries at all :)
Will do. |
Fixes #165
Related: #99, #60, #38
Note that I removed
check([0x4D, 0x34, 0x41, 0x20])
, at offset 0. I don't think this picking out any MPEG-4 audio file.