Add .stream() method

[bencmbrook]

This PR adds a method to support Node streams without causing side effects on the state of the stream. It reads in the minimum amount of bytes to detect the filetype, detects the file type, then rolls back the stream for use elsewhere.

Fixes #186

[sindresorhus]

Travis is failing

[bencmbrook]

Travis is failing

Interesting. Will look into it.

[bencmbrook]

Piping the readableStream through a PassThrough stream is a cleaner way of doing this because it preserves the event lifecycle and the stream flowing mode. Before, it was switching modes, which was causing it to break it Node 10.

This does require that we import the stream node module in index.js. I didn't use the ES6 module syntax there.

The open question then becomes, how do we want to keep this browser compatible? The stream method nor the require should be used in browsers.

[sindresorhus]

Piping the readableStream through a PassThrough stream is a cleaner way of doing this because it preserves the event lifecycle and the stream flowing mode. Before, it was switching modes, which was causing it to break it Node 10.

Agreed

The open question then becomes, how do we want to keep this browser compatible? The stream method nor the require should be used in browsers.

Webpack is super annoying in this sense and tries to import every require, even if it's behind an if-statement or not even used. One way to work around this is to use eval:

module.exports.stream = () => {
	const stream = eval('require')('stream');
	// …
};

[bencmbrook]

Bug found on the .rtf file. .read returns null. Should test all files.

https://github.com/bencmbrook/file-type/blob/929de6c441bc9b0c2cb6642f15a3d239ee7d6470/index.js#L928

[bencmbrook]

Features are done and tests are all passing. Anything you want changed in the latest commits?

[bencmbrook]

Marked everything as resolved

[bencmbrook]

🤙sweet. I'm gonna get a lot of use out of this.

Also, minor docs error on that readme commit: e8d4e1f#r32592498

[intellix]

PassThrough causes issues with rewind for me: #216

[bencmbrook]

How so? What version of file-type are you using?