Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Esri Shapefile #252

Merged
merged 2 commits into from Oct 31, 2019
Merged

Conversation

tmcw
Copy link
Contributor

@tmcw tmcw commented Oct 28, 2019

If you're adding support for a new file type, please follow the below steps:

  • One PR per file type.
  • πŸ‘ Add a fixture file named fixture.<extension> to the fixture directory.
  • πŸ‘ Add the file extension to the extensions array in supported.js.
  • πŸ‘ Add the file's MIME type to the types array in supported.js.
  • πŸ‘ Add the file type detection logic to the index.js file.
  • πŸ‘ Add the file extension to the FileType type in index.d.ts.
  • πŸ‘ Add the file's MIME type to the MimeType type in index.d.ts.
  • πŸ‘ Add the file extension to the Supported file types section in the readme, in the format - [`<extension>`](URL) - Format name, for example, - [`png`](https://en.wikipedia.org/wiki/Portable_Network_Graphics) - Portable Network Graphics
  • ο»ΏπŸ‘ Add the file extension to the keywords array in the package.json file.
  • πŸ‘ Run $ npm test to ensure the tests pass.
  • πŸ‘ Open a pull request with a title like Add support for Format, for example, Add support for PNG.
  • πŸ‘ The pull request description should include a link to the official page of the file format or some other source. Also include a link to where you found the file type detection / magic bytes and the MIME type.

@bencmbrook
Copy link
Contributor

Looks good to me!

@sindresorhus sindresorhus merged commit 54beff7 into sindresorhus:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Esri Shapefile support?
3 participants