Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ASF unit test #291

Closed
wants to merge 1 commit into from
Closed

Add ASF unit test #291

wants to merge 1 commit into from

Conversation

Borewit
Copy link
Collaborator

@Borewit Borewit commented Jan 4, 2020 •
edited

  1. Add ASF(https://en.wikipedia.org/wiki/Advanced_Systems_Format) / .asf file fixture.
  2. Remove ignore .asf fixture in unit tests.

Currently failing do to: #290, related to #240

Fixture information:

image

@Borewit Borewit mentioned this pull request Jan 4, 2020
Closed
4 tasks
@sindresorhus
Copy link
Owner

We should have an array of knownFailingTests or something in the test file that makes the test use test.failing() instead of test().

@Borewit
Copy link
Collaborator Author

Borewit commented Jan 6, 2020 •
edited

We should have an array of knownFailingTests or something in the test file that makes the test use test.failing() instead of test().

I could not agree more. Created a PR: #293 (for existing failing tests first)

@Borewit Borewit self-assigned this Jan 12, 2020
This was referenced Jan 17, 2020
Merged
Merged
@Borewit
Copy link
Collaborator Author

Borewit commented Jan 19, 2020

Replaced by #311, as the source branch vanished.

@Borewit Borewit closed this Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Borewit Borewit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Borewit @sindresorhus