Add support for SKP #351
Merged
Add support for SKP #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to add it to https://github.com/sindresorhus/file-type/blob/master/supported.js too. |
|
I already added the 'skp' extension to the |
+ fix package.json indentation
|
Looks good now. Thanks ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds support for the SketchUp file format. There is no public specifications, but the magic bytes are easily found (all .skp files start with the ASCII string
....S.k.e.t.c.h.U.p...M.o.d.e.l.). This page confirms the magic bytes.I did not find an official source for the mime-type, but
application/vnd.sketchup.skpis quite widely referenced on internet. This page references this mime type.This is my first PR (ever) to an open-source project, please tell me if there is anything I can improve!