Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sync word check at odd offsets for MPEG detection #448

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Remove sync word check at odd offsets for MPEG detection #448

merged 1 commit into from
Apr 13, 2021

Conversation

Borewit
Copy link
Collaborator

@Borewit Borewit commented Apr 12, 2021

Remove MPEG sync word check add offset 1.

Fix #445.

@Borewit
Copy link
Collaborator Author

Borewit commented Apr 12, 2021

Also did an integration tests with music-metadata, this change did not break anything.

@Borewit Borewit changed the title sindresorhus/file-typ#445 Remove check for sync word in odd offsets. sindresorhus/file-typ#445 Remove check for sync word at odd offsets. Apr 12, 2021
@sindresorhus sindresorhus changed the title sindresorhus/file-typ#445 Remove check for sync word at odd offsets. Remove moot check for sync word at odd offsets for MPEG detection Apr 13, 2021
@sindresorhus sindresorhus merged commit 7021d9a into main Apr 13, 2021
@sindresorhus sindresorhus deleted the remove-mpeg-odd-offset branch April 13, 2021 17:06
@Borewit Borewit changed the title Remove moot check for sync word at odd offsets for MPEG detection Remove sync word check at odd offsets for MPEG detection Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sindresorhus sindresorhus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MPEG sync check at odd offset required?
2 participants
@Borewit @sindresorhus