Prevent stripping of outer replaced characters. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Apr 23, 2023
filenamify.js
Outdated
|
|
||
| // Doesn't make sense to have longer filenames | ||
| const MAX_FILENAME_LENGTH = 100; | ||
|
|
||
| const reRepeatedReservedChars = /([<>:"/\\|?*\u0000-\u001F]){2,}/g; // eslint-disable-line no-control-regex |
There was a problem hiding this comment.
You did not fully address the feedback in #12 (comment)
There was a problem hiding this comment.
I didn't move it because i saw that reControlChars is also a g regex, and it's outside filenamify(). Should I move that too?
filenamify.js
Outdated
| @@ -58,3 +58,5 @@ export default function filenamify(string, options = {}) { | |||
|
|
|||
| return string; | |||
| } | |||
|
|
|||
| const trimRepeatedReservedChars = string => string.replace(reRepeatedReservedChars, '$1'); | |||
There was a problem hiding this comment.
Suggested change
| const trimRepeatedReservedChars = string => string.replace(reRepeatedReservedChars, '$1'); | |
| const trimRepeatedReservedCharacters = string => string.replace(reRepeatedReservedCharacters, '$1'); |
There was a problem hiding this comment.
I'm thinking about completely removing const trimRepeatedReservedChars, given that after moving the regex inside filenamify(), calling string.replace(...) inside the if statement would be the easiest way to do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11. Just like #12, "now we trim repeat and outer reserved chars before doing a global replace with the replacement char, to preserve instances of that char present in the original string".
The only difference is that I think we should maintain as much of the original string as possible, so we don't strip outer reserved characters, we only replace them with the replacement string.