Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to specify signal to send #31

Closed
juancampa opened this issue Feb 21, 2018 · 6 comments
Closed

No way to specify signal to send #31

juancampa opened this issue Feb 21, 2018 · 6 comments

Comments

@juancampa
Copy link

juancampa commented Feb 21, 2018

Is there a way to specify the signal to send to the process?

I understand that fkill is multi-platform but at least in Unix environment people regularly use both TERM and KILL, and possibly others like HUP

@kevva
Copy link
Contributor

kevva commented Feb 22, 2018

Why do you need it?

@juancampa
Copy link
Author

juancampa commented Feb 22, 2018

Sometimes programs intercept SIGTERM and don't really die, so you need to send SIGKILL (i.e. kill -9 <pid>). It's the difference of pressing the "Quit" button vs the "Force Quit" in macOS

@juancampa
Copy link
Author

juancampa commented Feb 22, 2018

SIGHUP is typically used to make a daemon reload its settings (e.g. prometheus/prometheus#1572)

@juancampa
Copy link
Author

This might be out of scope of fkill but I'd suggest it works like this:

  • $ fkill
  • find the process you want to kill
  • either:
    • press enter to send SIGTERM (just like it works today)
    • press tab to go to a different menu where you can select the signal, and press enter to send it

@kevva
Copy link
Contributor

kevva commented Feb 22, 2018

If you're using --force it'll use SIGKILL. But I suppose we could allow the user to specify whichever signal they want to use behind a signal option or something. @sindresorhus, what do you think?

@sindresorhus
Copy link
Owner

This CLI is for killing processes. Sending different signals is out of scope. We already support the most common use-case by killing normally or with --force. And in interactive mode, if killing a process fails, we offer to do it with force (SIGKILL).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants