Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process is not killed #42

Closed
capaj opened this issue Mar 19, 2018 · 11 comments · Fixed by #80
Closed

Process is not killed #42

capaj opened this issue Mar 19, 2018 · 11 comments · Fixed by #80
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@capaj
Copy link

capaj commented Mar 19, 2018

Issuehunt badges

I have a node.js process listening on port 3000 and I can't kill it.
image

Ubunut 17.10
Node 8.9.3


IssueHunt Summary

stroncium stroncium has been rewarded.

Backers (Total: $40.00)

Submitted pull Requests


Tips

@curtisbelt
Copy link

fkill :3000 -f

@capaj
Copy link
Author

capaj commented Mar 20, 2018

it would be nice if fkill would reflect the fact that it did not kill the process in the output. Also IMHO the default to forcibly kill it would make more sense to me. I mean if someone is installing fkill it is because they want to kill processes, not just ask them nicely to terminate.

@sindresorhus
Copy link
Owner

In the interactive interface, we detect if the process was killed or not and ask the user if they want to force kill. When using the non-interactive interface, like here, we could try to force kill if normal killing didn't work.

@sindresorhus sindresorhus changed the title process is not killed Process is not killed Mar 22, 2018
@IssueHuntBot
Copy link

@IssueHunt has funded $40.00 to this issue. See it on IssueHunt

@medusalix
Copy link

When using the non-interactive interface, like here, we could try to force kill if normal killing didn't work.

@sindresorhus Should we introduce a new flag for this behavior? Something like safe-kill? We could also just notify the user that a process is going to get killed forcibly when normal killing didn't work.

@sindresorhus
Copy link
Owner

I think we should try killing normally first and if that fails, we should force kill.

@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label May 10, 2019
@thepont
Copy link

thepont commented May 23, 2019

@sindresorhus that makes the assumption that fkill knows how long the process takes to cleanly shutdown. Perhaps if it prompts the user so they know they are about the rip the life from the process without giving it time to clean up.

@sindresorhus
Copy link
Owner

sindresorhus commented Feb 16, 2020

If anyone wants to work on this, see the initial attempt and feedback here: #70

@sindresorhus
Copy link
Owner

sindresorhus commented Sep 29, 2020

This is blocked by sindresorhus/fkill#44

@sindresorhus
Copy link
Owner

Abandoned attempt: #76

@issuehunt-oss
Copy link

issuehunt-oss bot commented Jul 10, 2021

@sindresorhus has rewarded $36.00 to @stroncium. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $4.00

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
6 participants