Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to close properly? #8

Closed
gblazex opened this issue Feb 22, 2016 · 9 comments
Closed

how to close properly? #8

gblazex opened this issue Feb 22, 2016 · 9 comments
Labels

Comments

@gblazex
Copy link

gblazex commented Feb 22, 2016

Awesome stuff.

But Ctrl + C on my Mac leaves a residue of the fkill interface (which can only be cleared if I issue new commands or hit Enter for a few times to clear all those lines).

how to close fkill properly?

@sindresorhus
Copy link
Owner

Can you share a screenshot of how it looks?
Probably an Inquirer.js (the lib used for creating the interactive menu).

@gblazex
Copy link
Author

gblazex commented Feb 23, 2016

(the new command is after I closed fkill with Ctrl+C)

screen shot 2016-02-23 at 08 52 07

@sindresorhus
Copy link
Owner

What Node.js version are you on? Does the same thing happen if you press Esc (you might have to press it multiple times to quit because of a Node.js bug).

@gblazex
Copy link
Author

gblazex commented Feb 23, 2016

Yes same with Esc.
Node 4.3.1 LTS

@gblazex
Copy link
Author

gblazex commented Feb 23, 2016

Doesn't happen for you?

(happens for me both on my local Mac or on servers I SSH into)
(also both Terminal.app and iTerm2)

@sindresorhus
Copy link
Owner

Doesn't happen for you?

Yes, but in a different way.

Anyways, I think I tracked it down. With this I can no longer reproduce it: mokkabonna/inquirer-autocomplete-prompt#14

@gblazex
Copy link
Author

gblazex commented Feb 23, 2016

👍

@mokkabonna
Copy link
Contributor

mokkabonna commented Feb 16, 2017

PR up for fixing this now: SBoudrias/Inquirer.js#500

@mokkabonna
Copy link
Contributor

mokkabonna commented Feb 22, 2017

Required PR now merged SBoudrias/Inquirer.js#500

So whenever that is released, and updated version in fkill, it will be working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants