Fix bufferedData being larger than maxBuffer
#89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.js
Outdated
| @@ -39,12 +39,13 @@ const getStreamContents = async (stream, {convertChunk, getSize, getContents}, { | |||
| for await (const chunk of stream) { | |||
| const chunkType = getChunkType(chunk); | |||
| const convertedChunk = convertChunk[chunkType](chunk, textDecoder); | |||
| chunks.push(convertedChunk); | |||
| length += getSize(convertedChunk); | |||
There was a problem hiding this comment.
Wouldn't the length be wrong here for the bufferedData on the error? Since when there is a MaxBufferError we skip the new chunks, but we still included the chunk size in the length sum.
There was a problem hiding this comment.
You're right!
Fixed in 35327d0
The test was not catching this because it was using getStream(), which does not use length to concatenate all chunks. I switched it to getStreamAsBuffer(), and the test was now failing. It is passing now.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error.bufferedDatashould be limited byoptions.maxBuffer, just like the return value is. This PR fixes this.