Avoid triggering access dialogs on macOS #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds useful, but it needs to be documented in the readme and index.d.ts. |
sindresorhus
reviewed
Apr 2, 2020
sindresorhus
reviewed
Apr 2, 2020
sindresorhus
reviewed
Apr 6, 2020
| @@ -1,4 +1,21 @@ | |||
| declare namespace activeWin { | |||
| interface Options { | |||
| /** | |||
| Disable Accessibility permission check (macOS) | |||
There was a problem hiding this comment.
The docs text should be in sync with the readme text.
I think each option should also describe what the effect of disabling it is, for example, the window title not being available.
sindresorhus
reviewed
Apr 6, 2020
| /** | ||
| Disable Accessibility permission check (macOS) | ||
| */ | ||
| accessibilityCheck: boolean; |
There was a problem hiding this comment.
Suggested change
| accessibilityCheck: boolean; | |
| readonly accessibilityCheck: boolean; |
sindresorhus
reviewed
Apr 6, 2020
| const result = activeWin.sync({ | ||
| accessibilityCheck: false, | ||
| screenRecordingCheck: false, | ||
| url: false, |
There was a problem hiding this comment.
Suggested change
| url: false, | |
| url: false |
sindresorhus
reviewed
Apr 6, 2020
| @@ -2,9 +2,14 @@ import {expectType, expectError} from 'tsd'; | |||
| import activeWin = require('.'); | |||
| import {Result, LinuxResult, MacOSResult, WindowsResult} from '.'; | |||
|
|
|||
|
|
|||
sindresorhus
reviewed
Apr 6, 2020
| @@ -47,11 +47,17 @@ const activeWin = require('active-win'); | |||
|
|
|||
| ### activeWin() | |||
There was a problem hiding this comment.
Suggested change
| ### activeWin() | |
| ### activeWin(options?) |
|
@drslump Friendly bump :) |
|
@drslump Bump |
|
@sindresorhus Why would you just close this PR and leave the issue open? It looks like it was a good work in progress. Wouldn't it make sense to touch up the PR in the ways you recommend and merge this in? |
This was referenced Jan 28, 2021
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent macOS versions the operating system is triggering accessibility dialogs asking the user if an operation should be allowed. Our application tries to guide the user through it as part of our onboarding setup.
So it'll be great if we can instruct active-win to skip functionality that would trigger those dialogs. For instance we already ask for the Screen Recording permission that provides the title, hence we shouldn't need the Accessibility one or inspect Chrome for the url since we don't require that information.
These changes allow to pass the following options:
accessCheck: false-- disables the accessibility checks and so the OS promptsappleScript: false-- disables the use of apple script (used to obtain the URL only)Hopefully this is something most people will find useful. And thanks for the library!