Add `.isAccessGranted()` method #90

Mubramaj · 2020-11-23T17:10:25Z

Added new method isAccessGranted that will return true if the app has the right access to perform the active window

This method is useful on MAC to avoid getting the activeWin if the access are not granted.

In my case I use activeWin in an Interval to check the foreground window. Without this method the dialogs to ask for permission are prompted again and again.

I don't know if it was in your road map but I am opening this pull request anyway.

…pp has the right access to perform the active window fixed typo removed unused console log

sindresorhus · 2020-11-23T18:01:44Z

There are multiple types of accesses. Do you think it's enough to just expose one method for all of them?

Mubramaj · 2020-11-23T18:24:52Z

You are right. There is 3 accesses right ?

I can work on this. Should I do 3 different methods for each access or one method that returns data for the 3 accesses ?

sindresorhus · 2020-11-23T18:40:13Z

I mean, can you imagine needing any of the specific ones instead of just all? I would prefer to keep it simple and do one method for all, but I'm curious if I'm missing any use-cases.

Mubramaj · 2020-11-23T19:01:29Z

Maybe some apps ask for the Accessibility permission during the Installation process but not the screen recording. Or the other way around.

I think making the method more general and returning a JSON with all the permission can be useful.

I will update my pull request

sindresorhus · 2020-11-24T15:21:37Z

Then I think there should also be an .all property for ease of use.

Package.swift

package.json

readme.md

index.d.ts

Sources/is-access-granted/main.swift

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>

Mubramaj · 2020-11-24T18:54:55Z

Then I think there should also be an .all property for ease of use.

You mean in the object returned by the isAccessGranted ?

By the way should I keep this name isAccessGranted , I think getPermissionStatuses is better

… name

sindresorhus · 2020-11-25T12:40:22Z

You mean in the object returned by the isAccessGranted ?

Yes

By the way should I keep this name isAccessGranted , I think getPermissionStatuses is better

I think isAccessGranted makes sense if the return value is:

{
  all: false,
  screen: true,
  accessibility: false
}

…es file

Mubramaj · 2020-11-25T22:41:21Z

I pushed the latest changes.

However I noticed that one last access is used for the URL of the browser. For this I saw that an apple script was used tell app \"Safari\" to get URL of front document . Unfortunately, I did not found a way to get this access without prompting the use with a dialog.
Interesting article unfortunately not working in this case

Couple possibilities:

Do not handle the URL in the isAccessGranted Method
Handle it but isAccessGranted method will trigger the pop up only once, the first time it's ran

Also I do noticed an Error on Mojave: Error: dydl Library not loaded but I think you already addressed it on:
#53

Mubramaj · 2020-12-07T19:17:48Z

Hi @sindresorhus any update on this pull request?

sindresorhus · 2020-12-09T07:35:20Z

Seems like it's possible: https://halmueller.wordpress.com/2018/09/04/privacy-consent-in-mojave-part-2-applescript/

index.d.ts

…sult depending on platform

sindresorhus · 2020-12-21T13:22:10Z

index.d.ts

+
+	/**
+	Resolves all the statuses of the accesses needed to check the active win
+	Returns an object of type AccessResult


This should use proper TS doc comment syntax for return value.

index.d.ts

sindresorhus · 2020-12-21T13:22:39Z

Sources/is-access-granted/utilities.swift

+        }
+      }
+    }
+    return false


Use tab-indentation

sindresorhus · 2020-12-21T13:23:03Z

Sources/is-access-granted/utilities.swift

+      }
+
+      // Don't check windows owned by this process
+      if windowProcessIdentifier == processIdentifier {


Use guard.

sindresorhus · 2020-12-21T13:23:22Z

Sources/is-access-granted/utilities.swift

+ */
+func isScreenRecordingGrantedNoDialog() -> Bool {
+  // The screen recording security was introduced in version 10.15 of MAC os
+  if #available(macOS 10.15, *) {


Use guard. Applies to many other places.

sindresorhus · 2020-12-21T13:23:44Z

Sources/is-access-granted/utilities.swift

+ *  CREDITS: https://gist.github.com/soffes/da6ea98be4f56bc7b8e75079a5224b37
+ */
+func isScreenRecordingGrantedNoDialog() -> Bool {
+  // The screen recording security was introduced in version 10.15 of MAC os


That's not how you write macOS.

index.js

sindresorhus · 2020-12-21T13:26:42Z

readme.md

@@ -71,6 +71,14 @@ Returns an `Object` with the result, or `undefined` if there is no active window
 - `url` *(string?)* - URL of the active browser tab if the active window is Safari, Chrome, Edge, or Brave *(macOS only)*
 - `memoryUsage` *(number)* - Memory usage by the window owner process

+### activeWin.isAccessGranted()
+
+Check if the package has enough access to get the active window.


This is not correct. It always has access, just not access to the window title, etc.

sindresorhus · 2020-12-21T13:26:57Z

readme.md

+
+Check if the package has enough access to get the active window.
+
+Returns `true` if there is enough access, `false` otherwise.


This is outdated.

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>

sindresorhus · 2021-03-07T08:27:33Z

Closing as this isn't moving forward and the PR is just too far from being mergable. Probably better to leave it to someone else.

Mubramaj · 2021-03-07T13:49:59Z

I read the article you sent me and did more research.
I tried experimenting the method AEDeterminePermissionToAutomateTarget described on the article to see if use granted permission to be able to send message from current App to other app (Like safari or Chrome) to get current URL.
However when the app is not running the return status is process not found .

Again this permission is only used to get Browser URL from active browser.
In my opinion the the statuses for accessibility and screen Recording permissions are enough

If you agree on keeping only this 2 I can work on the remaining comments you left to finalize this PR

feat: Added new method isAccessGranted that will return true if the a…

236ae03

…pp has the right access to perform the active window fixed typo removed unused console log

sindresorhus added 3 commits November 24, 2020 22:22

Update Package.swift

00a625c

Update macos.js

c083464

Update main.swift

b521fe5

sindresorhus requested changes Nov 24, 2020

View reviewed changes

sindresorhus changed the title ~~feat: Added new method isAccessGranted~~ Add .isAccessGranted() method Nov 24, 2020

sindresorhus reviewed Nov 24, 2020

View reviewed changes

Sources/is-access-granted/main.swift Outdated Show resolved Hide resolved

Mubramaj and others added 3 commits November 24, 2020 19:47

Update readme.md

7a13e1d

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>

Update Sources/is-access-granted/main.swift

270407a

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>

Update Sources/is-access-granted/main.swift

9d8f650

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>

Mubramaj added 7 commits November 24, 2020 23:17

fix: added 'is-access-granted' binary file to package.json

3c5fa26

fix: removed path to is-access-granted in package.swift (not needed)

0085035

fix(is-access-granted): Use dictionary instead of 'dict' for variable…

f31a0af

… name

fix: Don't use * in front.

e8583c2

fix: updated method to get status of screen recording permission

ac3bbe0

use package instead of app in the readme wording

e74a431

rollback on isScreenRecordingGranted method

4a5797a

Mubramaj added 2 commits November 25, 2020 19:48

fix(is-access-granted): Moved utilities functions to separate utiliti…

38bf339

…es file

fix(isAccessGranted): Method now returns JSON with all access statuses

440d4a9

Mubramaj requested a review from sindresorhus November 25, 2020 22:41

sindresorhus requested changes Dec 9, 2020

View reviewed changes

index.d.ts Show resolved Hide resolved

index.d.ts Outdated Show resolved Hide resolved

Mubramaj marked this pull request as draft December 15, 2020 20:24

Mubramaj added 2 commits December 15, 2020 21:57

fix: keep only 1 type for accessResult and do not return different re…

fa2c680

…sult depending on platform

fix: updated outdated comment for method isAccessGranted

44b2559

sindresorhus requested changes Dec 21, 2020

View reviewed changes

Mubramaj and others added 2 commits January 3, 2021 23:04

style: changed name of unsupported_platform_error_message variable

c196eaa

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>

format: removed blank line

1e0b86e

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>

Base automatically changed from master to main January 23, 2021 07:44

sindresorhus closed this Mar 7, 2021

sindresorhus mentioned this pull request Mar 7, 2021

Add isAccessGranted method #100

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `.isAccessGranted()` method #90

Add `.isAccessGranted()` method #90

Mubramaj commented Nov 23, 2020

sindresorhus commented Nov 23, 2020

Mubramaj commented Nov 23, 2020 •

edited

sindresorhus commented Nov 23, 2020

Mubramaj commented Nov 23, 2020

sindresorhus commented Nov 24, 2020

Mubramaj commented Nov 24, 2020

sindresorhus commented Nov 25, 2020

Mubramaj commented Nov 25, 2020

Mubramaj commented Dec 7, 2020

sindresorhus commented Dec 9, 2020

sindresorhus Dec 21, 2020

sindresorhus Dec 21, 2020

sindresorhus Dec 21, 2020

sindresorhus Dec 21, 2020

sindresorhus Dec 21, 2020

sindresorhus Dec 21, 2020

sindresorhus Dec 21, 2020

sindresorhus commented Mar 7, 2021

Mubramaj commented Mar 7, 2021 •

edited


		Check if the package has enough access to get the active window.

		Returns `true` if there is enough access, `false` otherwise.

Add .isAccessGranted() method #90

Add .isAccessGranted() method #90

Conversation

Mubramaj commented Nov 23, 2020

sindresorhus commented Nov 23, 2020

Mubramaj commented Nov 23, 2020 • edited

sindresorhus commented Nov 23, 2020

Mubramaj commented Nov 23, 2020

sindresorhus commented Nov 24, 2020

Mubramaj commented Nov 24, 2020

sindresorhus commented Nov 25, 2020

Mubramaj commented Nov 25, 2020

Mubramaj commented Dec 7, 2020

sindresorhus commented Dec 9, 2020

sindresorhus Dec 21, 2020

Choose a reason for hiding this comment

sindresorhus Dec 21, 2020

Choose a reason for hiding this comment

sindresorhus Dec 21, 2020

Choose a reason for hiding this comment

sindresorhus Dec 21, 2020

Choose a reason for hiding this comment

sindresorhus Dec 21, 2020

Choose a reason for hiding this comment

sindresorhus Dec 21, 2020

Choose a reason for hiding this comment

sindresorhus Dec 21, 2020

Choose a reason for hiding this comment

sindresorhus commented Mar 7, 2021

Mubramaj commented Mar 7, 2021 • edited

Add `.isAccessGranted()` method #90

Add `.isAccessGranted()` method #90

Mubramaj commented Nov 23, 2020 •

edited

Mubramaj commented Mar 7, 2021 •

edited