New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reversing priority of token and endpoint environment variables #16
Comments
Makes sense to me. @floatdrop @SamVerschueren Thoughts? |
Makes sense to me as well. The options object has higher priority then other global settings. |
Yep, options should not be overridden by globals. |
Alright. Let's do it. PR welcome. |
SamVerschueren
added a commit
that referenced
this issue
Apr 10, 2016
SamVerschueren
added a commit
that referenced
this issue
Apr 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Started as a line comment but let's make it an issue and fix/close it.
The readme says clearly:
Same for the endpoint.
Not sure what the logic was, but I think it would be preferable to use the environment variables only when no applicable argument is passed. An application could have a default token (the env.) but for whatever reason use another token on specific calls.
The module, readme and test would have to be updated. It could be considered a major change since it's reversing its meaning.
The text was updated successfully, but these errors were encountered: