Tabbing is broken in the edit view

[sindresorhus]

The Dimensions dropdown has the first focus, if you tab you get Width, then Height, then the trimmer view. Instead of the trimmer view, it should have been the "pixels/percentage" dropdown.

When the edit view is presented, if you press Shift+Tab, it moves to focus to the trimmer view, if you press Esc then, the trimmer is hidden. We should find a way to prevent the trimmer from disappearing.

I was also thinking, maybe we should make the trimmer view the initial first responder instead of the "Dimensions" dropdown. You would then be able to press Space to view the video, which is nicer, I think. We could make it so that when you tab once, the dimension dropdown is focused.

---

IssueHunt Summary

sergeykuryanov has been rewarded.

Backers (Total: $80.00)

• issuehunt ($80.00)

Submitted pull Requests

• #141 Fix Edit window tabbing

---

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.

---

IssueHunt has been backed by the following sponsors. Become a sponsor

[issuehunt-oss]

@issuehunt has funded $80.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[NehaKushwah993]

Hi, I think I can fix this issue. But first I don't know how can I create pull request because I am not able to create any sub_branch or branch. Please let me know that process so I will start my process for other issues as well.

[NehaKushwah993]

Hi, I have fixed this issue :

• Instead of the trimmer view, it should have been the "pixels/percentage" dropdown.
• we should make the trimmer view the initial first responder instead of the "Dimensions" dropdown.
• if you press Shift+Tab, it moves to focus to the trimmer view, if you press Esc then, the trimmer is hidden.

These 3 issues are fixed, please take a look in my pullRequest.

-Neha

[NehaKushwah993]

Hi, did you look in to this?

[NehaKushwah993]

Hey, should I send you it's video?

[issuehunt-oss]

@sindresorhus has rewarded $72.00 to @sergeykuryanov. See it on IssueHunt

• 💰 Total deposit: $80.00
• 🎉 Repository reward(0%): $0.00
• 🔧 Service fee(10%): $8.00