Add checkerboard background for the trim view #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Oct 7, 2019
Gifski/CheckerboardView.swift
Outdated
| class CheckerboardView: NSView { | ||
| let gridSize = CGSize(width: 10, height: 10) | ||
| let firstColor = NSColor.white | ||
| let secondColor = NSColor.lightGray |
There was a problem hiding this comment.
This is a bit too dark. I would use #d1d1d1 (preferably a semantic color close to this).
Gifski/CheckerboardView.swift
Outdated
| secondColor.setFill() | ||
|
|
||
| for y in 0...Int(bounds.size.height / gridSize.height) { | ||
| for x in 0...Int(bounds.size.width / gridSize.width) where x % 2 == y % 2 { |
There was a problem hiding this comment.
Use this for readability:
extension BinaryInteger {
var isEven: Bool { isMultiple(of: 2) }
var isOdd: Bool { !isEven }
}
Gifski/CheckerboardView.swift
Outdated
| import Cocoa | ||
|
|
||
| class CheckerboardView: NSView { | ||
| private let gridSize = CGSize(width: 10, height: 10) |
|
Nice trick! |
sindresorhus
changed the title
|
Should we use a dark checkerboard version in dark mode? |
I think we should. Maybe flip white to black for dark mode? |
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
|
@sindresorhus grid size 7px looks not okay at top, so I set 8px: |
sindresorhus
reviewed
Oct 7, 2019
Gifski/util.swift
Outdated
| static let first = NSColor(named: "CheckerboardFirstColor") ?? NSColor.white | ||
| static let second = NSColor(named: "CheckerboardSecondColor") ?? NSColor.lightGray | ||
| } | ||
| } |
There was a problem hiding this comment.
Put this in https://github.com/sindresorhus/Gifski/blob/master/Gifski/Constants.swift and you can just force-unwrap the colors.
|
Make the second color in dark mode |
|
Looks great 👌 |
sindresorhus
added a commit
that referenced
this pull request
Oct 8, 2019
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
SergeyKuryanov
deleted the
113-add-checkerboard-background-for-trimming-view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113
Seems like background color of
AVPlayerViewcan't be modified, but we can use a trick.We can add overlay with with a window for video preview. This makes effect of checkerboard background.
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor