Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'serviceworker' doesn't include everything from 'worker' #133

Closed
TBBle opened this issue Mar 26, 2018 · 2 comments
Closed

'serviceworker' doesn't include everything from 'worker' #133

TBBle opened this issue Mar 26, 2018 · 2 comments

Comments

@TBBle
Copy link

TBBle commented Mar 26, 2018

I just noticed, while setting up a new project, that the serviceworker list doesn't appear to include URL and fetch, while worker does. Since 'serviceworker' inherits from worker, according to MDN, this seems incorrect to me.

It's also possible I'm misunderstanding the issue. It also seems at a short glance that #82 will introduce inheritance so this would be magically solved in the future.

@TBBle TBBle changed the title ServiceWorker scope doesn't include everything from 'worker' 'serviceworker' doesn't include everything from 'worker' Mar 26, 2018
@TBBle
Copy link
Author

TBBle commented Mar 26, 2018

I've just realised that perhaps the intention is that the user must mark the file with both environments, since the serviceworker definition only includes those things that aren't included in worker.

/* eslint-env worker */
/* eslint-env serviceworker */

If that's the case, feel free to close this issue.

@sindresorhus
Copy link
Owner

You should not have to specify both. This is just an oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants