Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows compatibility for gitignore option #171

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

barak007
Copy link
Contributor

@barak007 barak007 commented Mar 21, 2021

Fixes #153

@sindresorhus
Copy link
Owner

This needs a test.

@barak007
Copy link
Contributor Author

barak007 commented Mar 21, 2021

Sorry for the description-less PR. I was in a harry and forgot to write a description.
This should fix a case that ensureAbsolutePathForCwd received a cwd Windows path and a path to check which is also Windows path.
It was clear that if you only apply slash to one of them it wont work.

The whole slashes approach is usually not that promising. but I couldn't change the entire codebase.

@sindresorhus sindresorhus changed the title fix: Windows compatibility for ensureAbsolutePathForCwd Fix Windows compatibility for gitignore option Mar 22, 2021
@sindresorhus sindresorhus merged commit f67edfe into sindresorhus:main Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ensureAbsolutePathForCwd method issue
2 participants