Make sure JSON body will default to POST

Fixes #736
sindresorhus · Feb 22, 2019 · 90325bd · 90325bd
1 parent 4bad8f0
commit 90325bd
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/source/normalize-arguments.js b/source/normalize-arguments.js
@@ -206,8 +206,6 @@ const normalize = (url, options, defaults) => {
 
 	if (options.method) {
 		options.method = options.method.toUpperCase();
-	} else {
-		options.method = is.nullOrUndefined(options.body) ? 'GET' : 'POST';
 	}
 
 	if (!is.function(options.retry.retries)) {

diff --git a/source/request-as-event-emitter.js b/source/request-as-event-emitter.js
@@ -312,6 +312,10 @@ module.exports = (options, input) => {
 				options.body = JSON.stringify(options.json);
 			}
 
+			if (!options.method) {
+				options.method = is.nullOrUndefined(options.body) ? 'GET' : 'POST';
+			}
+
 			// Convert buffer to stream to receive upload progress events (#322)
 			if (is.buffer(body)) {
 				options.body = toReadableStream(body);

diff --git a/test/post.js b/test/post.js
@@ -141,3 +141,8 @@ test('content-type header is not overriden when object in options.body', async t
 test('throws when form body is not a plain object or array', async t => {
 	await t.throwsAsync(got(`${s.url}`, {form: 'such=wow'}), TypeError);
 });
+
+test('setting JSON will default to POST', async t => {
+	const {headers} = await got(s.url, {json: {foo: 'bar'}});
+	t.is(headers.method, 'POST');
+});