Fix throwing errors when using got.stream() (#550)

sindresorhus · Aug 9, 2018 · ae5b114 · ae5b114
1 parent ecf3180
commit ae5b114
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/source/create.js b/source/create.js
@@ -20,7 +20,11 @@ const create = defaults => {
 			options = mergeOptions(defaults.options, options);
 			return defaults.handler(normalizeArguments(url, options, defaults), next);
 		} catch (error) {
-			return Promise.reject(error);
+			if (options.stream) {
+				throw error;
+			} else {
+				return Promise.reject(error);
+			}
 		}
 	}
 

diff --git a/test/error.js b/test/error.js
@@ -133,3 +133,9 @@ test.serial('catch error in mimicResponse', async t => {
 
 	await t.throws(proxiedGot(s.url), {message: 'Error in mimic-response'});
 });
+
+test('errors are thrown directly when options.stream is true', t => {
+	t.throws(() => got(s.url, {stream: true, body: {}}), {
+		message: 'The `body` option must be a stream.Readable, string or Buffer'
+	});
+});