Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

got actually need nodejs >= 10.9, not >= 10 #1130

Closed
2 tasks done
Ivlyth opened this issue Mar 24, 2020 · 1 comment · Fixed by #1051
Closed
2 tasks done

got actually need nodejs >= 10.9, not >= 10 #1130

Ivlyth opened this issue Mar 24, 2020 · 1 comment · Fixed by #1051
Labels
question The issue is a question about Got

Comments

@Ivlyth
Copy link

Ivlyth commented Mar 24, 2020

Describe the bug

  • Node.js version: 10.2
  • OS & version: MacOS

got actually need nodejs >= 10.9, not >= 10

the request function prototype used in GOT was appeared in NodeJS 10.9:

https://github.com/sindresorhus/got/blob/master/source/request-as-event-emitter.ts#L246

https://nodejs.org/docs/latest-v10.x/api/http.html#http_http_request_options_callback

image

Checklist

  • I have read the documentation.
  • I have tried my code with the latest version of Node.js and Got.
@sindresorhus
Copy link
Owner

It's expected that users upgrade patch versions of a Node.js minor version. Without doing so, you're leaving yourself unpatched to lots of security issues.

Relevant: sindresorhus/meta#8

We'll bump the version in package.json to >=10.19 (or newer) when we do the next major version of Got.

@szmarczak szmarczak added the question The issue is a question about Got label Mar 24, 2020
szmarczak added a commit to szmarczak/got that referenced this issue Apr 1, 2020
@szmarczak szmarczak mentioned this issue Apr 1, 2020
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question The issue is a question about Got
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants