-
-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Response.body
is always empty
#1349
Comments
Latest Got (11.5.0) On my end the body is empty on Node.JS 14.0.0, but it works fine on 14.5.0 (latest version). |
Tested on all [supported] latest Node.js and it works as expected. Please update your Node.js version. |
@szmarczak Are you collecting points by quickly closing the issues? When someone creates an issue, they are not opening it to just have fun. First try to have a dialogue. But anyways Here's the output of tests on node If you suggest to upgrade to |
ping @sindresorhus ^^ |
Closing an issue just means it's resolved from our perspective. It doesn't mean we won't respond to additional comments.
Uhm, the bug is fixed. |
I feel like you're assuming this is a Got bug, while in fact most bugs in Got are really Node.js bugs. It's just that Got is a heavy user of the Node.js HTTP and stream APIs so Node.js bugs become quite apparent here. We cannot reasonable work around all the Node.js bugs, especially not ones that are already fixed in Node.js patch versions. By not upgrading patch versions, you're also exposing yourself to security vulnerabilities. For reference, @szmarczak has opened 33 Node.js issues and that's just a small percentage of all the bugs we have encountered. |
Never strictly said it is a got bug. Also, it is impossible for an outsider to know which bugs falls in the Node.js land and which falls in Got land (you guys have history with the module, so understand the blurry lines better) Was trying to report what I discovered and shared proper context
|
You reported a bug and we provided a solution. I don't really see what the issue is here. |
To add to the discussion, I found that node.js versions Upgrading to at least >= |
Describe the bug
v14.0.0
MacOS Catalina
11.5.0
Trying to make a very simple HTTP request and the response body is always empty. Tried reading the docs couple of times, ensuring I haven't missed anything. But nope.
Actual behavior
The
response.body
is an empty stringExpected behavior
Should return the response returned by the server
Code to reproduce
Just to make sure, that there isn't anything wrong on my end. I also tried using the Node.js
http
client to make the request to the same URL and it works fine.Sample code for same
In action
Checklist
The text was updated successfully, but these errors were encountered: