-
-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParseError should contain err.statusCode #182
Comments
👍 |
Yes, it should for consistency, because other errors have these fields. |
PR done. |
floatdrop
added a commit
that referenced
this issue
Mar 3, 2016
Add statusCode to ParseError, closes #182.
floatdrop
pushed a commit
that referenced
this issue
Mar 3, 2016
I haven't added because thats already covered in the error introduction:
Still do you want the |
Oh nvm you added that recently aha. 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
curl -v https://api.github.com/repos/震动/generator-test
should output a json but it does print an HTML pages, which gives aParseError
if we usegot()
withoptions.json=true
. Though, I was expecting that the ParseError contained theerr.statusCode
property, which doesn't at the moment. It has to be accessed viaerr.response.statusCode
which kind sucks :(Thoughts?
The text was updated successfully, but these errors were encountered: