Request body can't be querystring.parse(str)

[bisubus]

When the request is supplied with body that differs from { ... } object, it throws

options.body must be a ReadableStream, string, Buffer or plain Object

is-plain-object expects an object to inherit from either null or Object directly.

This makes

got.post(url, { data: querystring.parse(query) });

to fail, because querystring.parse(...) object inherits from empty object that inherits from null.

This looks more like a bug rather than zealous sanitization.

[floatdrop]

@bisubus I see positive side in this – you should explicitly set fields, that you are sending.

P.s. why you are passing result of querystring.parse to body? Why not just pass query as is?

[bisubus]

@floatdrop Why to not just get own enumerable properties from the object in this case? As for the example above, the workaround should be Object.assign({}, querystring.parse(query)), it doesn't add much clarity.

I'm quite sure (don't have this piece of code at hand at this moment) that this was done because got.post(url, { data: query }) makes a text/plain request and not application/x-www-form-urlencoded, not a very good thing for POST request (maybe a subject for another issue?)

[floatdrop]

makes a text/plain request and not application/x-www-form-urlencoded, not a very good thing for POST request (maybe a subject for another issue?)

This is right behaviour, if you pass String to body. Maybe we should move from is-plain-obj to is-obj.

@bisubus mind to make a PR?

[bisubus]

@floatdrop

Sure, will do this. I see that is-obj allows functions. Wouldn't it be better to stick to util.isObject instead?

[sindresorhus]

@bisubus Functions are objects. util.isObject is deprecated.

[bisubus]

@sindresorhus That's correct. This requires this spec to be fixed but otherwise it looks fine. Function type shouldn't be reserved for future use as callbacks here, should it?

[sindresorhus]

@bisubus We could always just do isObj(body) && body !== 'function'.

[bisubus]

@sindresorhus My guess that the code cannot gain much from is-obj dependency then, right?