allow non-plain object as request body #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@sindresorhus test on this would be nice 🦄 |
|
Agreed. @bisubus Would you mind adding a test and fixing the merge conflict? |
|
@sindresorhus Sure thing, I'll get down to this PR a bit later. |
|
@sindresorhus Added a couple of tests to match an object that can be passed as a body, since it is no longer validated by |
|
@bisubus thank you! 🎉 |
floatdrop
pushed a commit
that referenced
this pull request
Nov 1, 2016
* allow non-plain object as request body * add tests for object request body * fix test for non-plain object request body * fix tests to pass linter
|
Was this PR reverted? Seems the validator is still using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #212