Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide failing test for #1046 #1047

Closed
wants to merge 2 commits into from

Conversation

ohana54
Copy link

@ohana54 ohana54 commented Feb 3, 2020

No description provided.

test/error.ts Outdated Show resolved Hide resolved
test/error.ts Outdated Show resolved Hide resolved
Co-Authored-By: Szymon Marczak <36894700+szmarczak@users.noreply.github.com>
@szmarczak
Copy link
Collaborator

Test was expected to fail, but succeeded, you should stop marking the test as failing

Hmm... That's weird. Actually, wait, it's not weird. There is an unhandled error, because you didn't catch the error event on the file stream itself:

await pipeline(
httpOptions.body!,
uploadStream,
request
);

stream.pipeline it causes all streams to emit an error.

@sindresorhus I'm starting to think that switching to stream.pipeline wasn't a good idea 🤷‍♂️

@szmarczak
Copy link
Collaborator

It's already fixed

@szmarczak szmarczak closed this Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants