Wait until body file descriptor is open #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szmarczak
commented
Feb 6, 2020
source/create.ts
Outdated
|
|
||
| options.body.once('error', errorHandler); | ||
|
|
||
| // @ts-ignore Each member of the union type '...' has signatures, but none of those signatures are compatible with each other |
There was a problem hiding this comment.
I think it just says that result can be either or a stream or a promise and it doesn't know what types to choose
|
Or it could be done via a promise that waits until |
szmarczak
changed the title
sindresorhus
reviewed
Feb 7, 2020
| @@ -1,3 +1,4 @@ | |||
| import {ReadStream} from 'fs'; | |||
There was a problem hiding this comment.
Generally, it's nicer to rename generic imports like this as it's not immediately clear further down in the code that it's an fs read stream.
import {ReadStream: FsReadStream} from 'fs';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1046