Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing types #1125

Merged
merged 2 commits into from
Mar 29, 2020
Merged

Add missing types #1125

merged 2 commits into from
Mar 29, 2020

Conversation

yoannmoinet
Copy link
Contributor

@yoannmoinet yoannmoinet commented Mar 20, 2020 •
edited

Motivation

Running a typecheck with Yarn 2 failed because of missing types.

Screenshot 2020-03-20 at 09 25 48

Changes

  • added @types/responselike and @types/keyv

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates.

@yoannmoinet yoannmoinet mentioned this pull request Mar 20, 2020
Merged
@sindresorhus
Copy link
Owner

keyv is not a dependency. It should stay in devdependencies.

@yoannmoinet
Copy link
Contributor Author

There's a mention of it in shipped code though, in dist/source/types.d.ts which is used for typechecking our code.

@yoannmoinet
Copy link
Contributor Author

Oh wait 🤦‍♂

I guess having just the types in dependencies would be enough to fix this.
I'm moving keyv back.

@sindresorhus sindresorhus merged commit 74d66b2 into sindresorhus:master Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yoannmoinet @sindresorhus