Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for options.allowGetBody #1190

Merged
merged 3 commits into from
Apr 26, 2020
Merged

Add more tests for options.allowGetBody #1190

merged 3 commits into from
Apr 26, 2020

Conversation

PopGoesTheWza
Copy link
Contributor

To help investigate #1186 this PR adds:

  • withBodyParsingServer helper to allow the use of request.body in test cases
  • two test cases for using allowGetBody with a json payload

Adding more allowGetBody with non-json payloads might be relevant but not in the current scope of originating issue.

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates.

test/pagination.ts Outdated Show resolved Hide resolved
Co-Authored-By: Szymon Marczak <36894700+szmarczak@users.noreply.github.com>
@szmarczak szmarczak changed the title test cases for #1186 (allowGetBody and json payload) Add more tests for options.allowGetBody Apr 26, 2020
@szmarczak szmarczak merged commit d087215 into sindresorhus:master Apr 26, 2020
@szmarczak
Copy link
Collaborator

Thanks for submitting! 😃

@PopGoesTheWza PopGoesTheWza deleted the 1186 branch April 26, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants