Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the host header on redirect #1241

Merged
merged 3 commits into from May 10, 2020
Merged

Conversation

MittWillson
Copy link
Contributor

@MittWillson MittWillson commented May 9, 2020

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates.

Fixes #1240

@szmarczak
Copy link
Collaborator

This is missing a test

@MittWillson MittWillson closed this May 9, 2020
@MittWillson
Copy link
Contributor Author

MittWillson commented May 9, 2020

@satazor I tested it again, i was wrong, this is not an issue, sorry

@MittWillson
Copy link
Contributor Author

MittWillson commented May 9, 2020

This is missing a test

Hi, i tryied debug agian for reason, and i found why, host in options.headers replaced the finnal reuqest, is this a bug or feature?

if it is not a bug, i'll reclose this PR

thanks

@MittWillson MittWillson reopened this May 9, 2020
@szmarczak
Copy link
Collaborator

This is definitely a bug. Nice one! I'll look into this tomorrow, it's quite late here.

@MittWillson
Copy link
Contributor Author

@szmarczak sure, and glad to hear that :)

@szmarczak szmarczak changed the title fix: host of redirecting request headers Remove the host header on redirect May 10, 2020
@szmarczak szmarczak merged commit 8ff71d9 into sindresorhus:master May 10, 2020
@szmarczak
Copy link
Collaborator

Nice one, thanks! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redirecting request has wrong host
2 participants