Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set default value for opts.retiries if timeout is present. #198

Closed
wants to merge 1 commit into from

Conversation

Firnis
Copy link

@Firnis Firnis commented May 11, 2016

It quite isn't right to retry request 5 times when timeout is present in options.

@SamVerschueren
Copy link
Contributor

Why isn't that correct? A timeout is per individual call.

Let's say I have an endpoint and I set the timeout to 10 seconds. With this PR, this means that my retry count is set to 0 and will stop executing if the first call fails due to a network error. timeout and retries or 2 separate settings, I don't believe there is a link between those two.

@Firnis
Copy link
Author

Firnis commented May 11, 2016

But if your endPoint is not answering, then you will be waiting 5*10 seconds.
I see your point, but you can set count of retries manually if you need.

@Firnis Firnis force-pushed the master branch 4 times, most recently from f22bfb5 to fbe10a7 Compare May 11, 2016 12:50
@sindresorhus
Copy link
Owner

This is not a solution we're interested in. I do however see that it how it works can be an issue. I don't really have a solution, but happy to discuss in an issue if you have a better proposal :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants