Add a requestUrl property to the response object
#205
Conversation
| @@ -127,7 +127,7 @@ Option accepts `function` with `retry` and `error` arguments. Function must retu | |||
|
|
|||
| ###### followRedirect | |||
|
|
|||
| Type: `boolean` | |||
There was a problem hiding this comment.
This is just a trailing space
There was a problem hiding this comment.
@luanmuniz this will remove line breake before Default. You can see it in md preview.
There was a problem hiding this comment.
I just added a <br> like in the other lines
sindresorhus
changed the title
requestUrl property to the response object
|
@floatdrop You good with this? |
| @@ -41,6 +41,10 @@ test('empty response', async t => { | |||
| t.is((await got(`${s.url}/empty`)).body, ''); | |||
| }); | |||
|
|
|||
| test('requestUrl response', async t => { | |||
| t.is((await got(s.url)).requestUrl, `${s.url}/`); | |||
There was a problem hiding this comment.
Can you add a test with object {host: s.host, port: s.port} as argument?
There was a problem hiding this comment.
I think its done. Can you check if what i did is what you ask for?
| @@ -106,6 +106,7 @@ function asPromise(opts) { | |||
| const limitStatusCode = opts.followRedirect ? 299 : 399; | |||
|
|
|||
| res.body = data; | |||
| res.requestUrl = opts.href || urlLib.resolve(urlLib.format(opts), opts.path); | |||
There was a problem hiding this comment.
Won't res.requestUrl = urlLib.format(opts); suffice?
There was a problem hiding this comment.
No, when sending an object we don't have opts.href and urlLib.format(opts) don't return the opts.path in it. I just put the opts.href because if it exist we don't need to send to the functions. But it is removable.
|
LGTM |
|
👍 |
* Add requestUrl to response, update documentation and tests * Add test when redirect * Fix return description * Add tests with params and fix test * Add linebreak
Update from #188
Needed a new PR because the previous repository doesn't exist anymore and because of this is impossible to update that one. (Sorry about that)
@sindresorhus Is this what you meant in #188?
By the way: My writing in english os not very good so please take a look if it doesn't have any gramatical mistakes
cc @floatdrop