Handle errors thrown synchronously by http.request().

[satazor]

const got = require('got');

got('htttp://google.com')
.then((res) => console.log('res', res), (err) => console.log('error', err));

The code above fails globally because htttp is not a valid protocol. This PR fixes it.

[floatdrop]

I believe this code should catch such errors (and we have similar test).

Also this test is green:

test('invalid url', async t => {
    got('htttp://google.com').then(t.fail).catch(err => {
        t.regex(err.message, /Protocol .+ not supported/);
        t.pass();
    });
});

Can you make a PR with failing test?

[satazor]

@floatdrop sorry the test is wrong, I should have used got.stream since the bug is there.

How should we adjust this then?

[satazor]

@floatdrop maybe it's ok to throw synchronously since this method does not return a promise?

[floatdrop]

maybe it's ok to throw synchronously since this method does not return a promise?

@satazor I think so.

[satazor]

Agree! Closing this.