-
-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix location encoding #214
Conversation
Needs a test |
On it |
// @jamestalmage FYI, for follow-redirects. |
@sindresorhus Its fixed, but i'm having a small problem if compatibility. I found 2 ways to fix this: While the first one is deprecated in v6 the second doesn't exist in v4 and since the tests check for 4, 5 and 6 i don't know how it should be. Obs.: It's working with the first option |
@sindresorhus Done. Ready to merge Just one thing. I tried to add the following test:
But than the |
@sindresorhus Anything else to do here? |
@luanmuniz lgtm, thanks ⭐ |
See nodejs/node#7928