Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add requestUrl to response in streaming mode #230

Merged
merged 2 commits into from Oct 20, 2016
Merged

Add requestUrl to response in streaming mode #230

merged 2 commits into from Oct 20, 2016

Conversation

kevva
Copy link
Contributor

@kevva kevva commented Oct 19, 2016

Fixes #229.

@sindresorhus
Copy link
Owner

sindresorhus commented Oct 19, 2016 •
edited

We now set requestUrl twice in different places. I think we could set it once in the requestAsEventEmitter instead, though haven't tested it.

@kevva
Copy link
Contributor Author

kevva commented Oct 20, 2016

@sindresorhus, done.

@sindresorhus
Copy link
Owner

@floatdrop LGTY?

@floatdrop floatdrop merged commit 205e224 into master Oct 20, 2016
@floatdrop floatdrop deleted the url-prop-stream branch October 20, 2016 18:44
@floatdrop
Copy link
Contributor

👍

@floatdrop floatdrop mentioned this pull request Oct 26, 2016
Closed
floatdrop pushed a commit that referenced this pull request Nov 1, 2016
@kevva @floatdrop
Add requestUrl to response in streaming mode (#230)
5c71272 
* Add `requestUrl` to response in streaming mode (Fixes #229).
* Set `requestUrl` inside `requestAsEventEmitter()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevva @sindresorhus @floatdrop