Add json extension to require package. Fixes webpack v2 beeing unable…

[cgrossde]

Webpack v2 doesn't allow empty extensions anymore: webpack/webpack#3043

Running webpack v2 on a project with got will result in the following error:

ERROR in ./~/got/index.js
Module not found: Error: Can't resolve './package' in '...'
 @ ./~/got/index.js 19:12-32
 @ ./~/is-reachable/index.js
...

Adding the .json extension to require('./package') => require('./package.json') fixes the problem.

[sindresorhus]

I don't really see how that's something Got should fix. It is Webpack not following the Node.js resolution logic.

// @TheLarkInn

[julien-f]

@sindresorhus I think it makes sense to add extensions for non-js files.

Anyway it seems like a fairly minor change to help people using Webpack.

[cgrossde]

@sindresorhus I agree that this is webpack not following require convention. However you would do me a big favour in merging this. It would be an easy fix for anyone using webpack with your package. It could be weeks until webpack fixes this. It also has no effect on your code.

[TheLarkInn]

@sindresorhus what part of the pattern is off?

[TheLarkInn]

Um so webpack does have extentions for .js and .json by default (in that respective order)

[TheLarkInn]

@cgrossde can you please share your webpack config for me, I have a suspicion that you have resolveExtentions overrides incorrectly

[cgrossde]

@TheLarkInn, damn you are right. I was migrating vom webpack v1 to v2 and never thought of adding new extensions, just removed the empty one.
Before (webpack v1):

resolve: {
    extensions: ['', '.js', '.jsx', '.scss']
  },

After (webpack v2) - results in the mentioned error:

resolve: {
    extensions: ['.js', '.jsx', '.scss']
  },

Solution:

resolve: {
    extensions: ['.js', '.jsx', '.scss', '.json]
  },

Sry guys, was working on it after a long day at work. Missed the obvious.

[TheLarkInn]

@sindresorhus thanks fur the ping 🐶

[TheLarkInn]

@cgrossde no prob you can always check webpack.js.org/configuration to see the defaults. In this case the array is an complete override so order is important.

[TayBill]

Ran into this problem with an Angular2 based app, the angularcli, and default assumptions about webpack. The recommended approach was was run ng eject to generate a non default webpack config file. That all worked, but ended up making big changes to my package.json. The changes were big enough that I'm not going to continue with this approach. Bottom line: It sure would be nice if this merge request (changing from package to package.json) was accepted. It would make things a lot simpler. See also #285

[sindresorhus]

@TheLarkInn Webpack should resolve .json in sub-dependencies no matter what people define in the extensions option. This is how the Node.js require resolving works and by giving people ability to shoot themselves in the foot by forgetting to include .json when they override the option, Webpack ends up just wasting everyone's time in issues like this. (I've had to deal with this problem at least 10 times in the past).

I'm not going to change anything in Got as it's Webpack that is not compatible with Node.js and I'm tired of all the churn. People always want the easy solution instead of fixing the actual problem.