Split index.js into separate files
#500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon93s
commented
Jul 6, 2018
| const mimicResponse = () => { | ||
| throw new Error('Error in mimic-response'); | ||
| }; | ||
| mimicResponse['@global'] = true; |
There was a problem hiding this comment.
Not best practice to use @global with proxyquire but it does not currently result in any side-effects in the tests. An alternative would be to introduce a mimic-response-wrapper.js that exports a named function we can stub with Sinon and then use that in got.
There was a problem hiding this comment.
Nah, I think what you have here is fine.
sindresorhus
changed the title
index.js into separate files
|
Really good! 🙌 |
|
@brandon93s some part of me had been wanting to do this PR for soooo long haha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits the got codebase into its sub-components.